Kate Lovett comments

Results 588 comments of


                                            Kate Lovett

Add sample code for AutomaticKeepAliveClientMixin.

@SohanRaidev would you like to continue working on this change? It looks like some tests are failing and we also need more tests provided for the change.

Fix RefreshIndicator sensitivity with NestedScrollView by using render size.

> Column -> Expanded -> RefreshIndicator -> Container -> SingleChildScrollView (always scrollable scroll physics) -> with minimal content, not enough to scroll. Currently the refresh indicator can be used in...

No stacktrace chaining during flutter tests

If this is a regression, do we know when it last worked as expected?

CupertinoSheetRoute with scrolling and dragging

> CupertinoSheet currently does not add a drag handle. For the native sheet widget, the drag handle is normally added when the sheet is resizable @MitchellGoodwin have you checked the...

Change the default theme of selected items from green to something

@chunhtai is this maybe the accessibility focus box? Do we have control over how that presents itself?

Skip HardwareKeyboard asserts until keyboard state is initialized

Hey @richard457 does this documentation on seeing test results help? https://github.com/flutter/flutter/blob/master/docs/contributing/testing/Fix-failing-checks.md

Skip HardwareKeyboard asserts until keyboard state is initialized

Do you mean rebase? Tip of tree is currently the master branch.

Skip HardwareKeyboard asserts until keyboard state is initialized

Hey @richard457 would you like to continue working on this change?

[web] Flutter errors should be reported with console.error()

(Flyby comment from triage): There are some failing checks currently.

Fix pinned header in NestedScrollView

> I wonder though if Google testing will uncover something. IIRC I looked at this a couple years ago, but I do not recall what prevented a fix from landing....