Kate Lovett

Results 588 comments of Kate Lovett

FYI @johnpryan I don't have assigning permissions 😁

Greetings from stale PR triage! 👋 Is this change one you would still like to pursue?

> This is more of an 'ideas' changeset, rather than one i expect to be merged. Thanks for explaining! We should probably close this then, and focus discussion of ideas...

> So the right answer here is probably to have a second place to look for fixes related to dart: libraries. That would be great @bwilkerson! If so, we'd probably...

> a second place to look for fixes related to dart: libraries. It was suggested that if we do this, we'd probably hope to be able to then put all...

Oh ok. I think it was because folks said they would prefer if fixes were centrally located.

It currently lives here: https://github.com/flutter/flutter/tree/master/packages/flutter/lib/fix_data :)

Yes I understand from our earlier discussion. I was just answering the question. :) If putting the fix data works best in another location, we'll put it there.

Happy to defer to you all since I don't feel qualified to choose.

From @jason-simmons (thanks!): The build action that generates the sky_engine package is: https://github.com/flutter/flutter/blob/master/engine/src/flutter/sky/packages/sky_engine/BUILD.gn#L281 The new Dart fix YAML file can be placed somewhere in the engine source tree and then...