Pieter Cardillo Kwok

Results 68 comments of Pieter Cardillo Kwok

@kennethnrk - Thanks for reviewing! About your concern about the screenshots in the docs (points 1 & 2), those will be updated once #29857 has been taken care of. It's...

Alright. I'll tag my mentor for mentor review next, I think the issues we discussed above can be resolved in parallel with the more code reviews (?).

@zulipbot add "mentor review" @sbansal1999 I'll tag this one for mentor review, thank you

Update: Resolved merge conflict,

Update: Finished writing the updated newrelic doc. The screenshot for the integration doc in the PR description has been updated

> I'm talking about the video when you click on **Webhook** under **Integration details** here: https://docs.newrelic.com/docs/alerts/get-notified/notification-integrations/ Yeah, I think that video guide is outdated. The UI looks different and some...

@zulipbot remove "buddy review"

@laurynmm Sorry for the late response and thank you for reviewing this! I've pushed new changes to address your reviews and replied to some of your comments. I've also updated...

Update: resolved merge conflict

Hmm, what would be a good way to handle `incident_empty_timestamp_payload.json`. With the new changes, this payload will pass `payload_has_expected_fields()` check but the expected fields (`createdAt` & `updatedAt`) are technically None...