Pieter Cardillo Kwok
Pieter Cardillo Kwok
@karlstolley If that's the case for the table border color, shouldn't the other parts of the table also be refactored in the same way? The obvious one I noticed is...
> You can just post a comment to note that the description has been updated. Ahh, gotcha. I agree, this seems cleaner. Will do! :smiley:
Update: Added new prep commit to refactor thead background color and called a potential issue/ bug. All details are in the updated PR desc.
> A few code-organization nits. I'm not certain we won't see some regressions from striking those table-oriented element selectors in dark mode, but the fixes for those would be to...
@ecxtacy Hello! Good work here, are you still working on this PR? I noticed that it has been a while since you've updated it, I'm willing to pick it up...
> Hi @PieterCK , you can pick up the work. In case you need assistance feel free to contact me. Thanks. OK, thanks for confirming. I'll fork your PR and...
Update: Resolved conflict
Hi @laurynmm, thanks for doing an initial code review for this PR. I've addressed your comments and updated the commit for this PR. Let me know if any recent changes...
> I haven't done any manual testing yet, so it might be good to update this and then have your GSoC code buddy do a review with some manual testing...
Thanks for the reviews, Lauryn! Let me know if the new changes have addressed your comments.