Pierre Sassoulas

Results 541 comments of Pierre Sassoulas

Nice 🧠 ! Yes, permitting to inject a comparison function on the plugin side and provide semver by default in pylint "core" would be a really nice design. ```python from...

I'm not sure what you mean by that, could you upgrade the ``_esoteric_lib_comparator`` example for it to be a ``Callable[[], bool] | None`` ? I suppose we must provide target...

Ha, right, I understand. Are there a lot of other ways to recover the version ? Maybe we could provide another injection point for that if that's the case: ```python...

+1 from me. It also seems relatively immune to false positive and simple without looking too much into it. How would you name it ? ``useless-string``, ``useless-fstring-formatting`` ``useless-format-string`` ?

Not sure what the false positive is in this case @DanielNoord ? Isn't ``print(f"{x}" + "B")`` an actual issue ? As it should be ``print(str(x) + "B")`` to be equivalent...

Right. Still + 0.5 on this, but it's less useful if it become ``consider-f-string-uselessness`` and a convention check, for sure.

Yes, I closed https://github.com/pylint-dev/pylint/issues/9477 as a duplicate of this one :)

You're also going to need to add a changelog entry, see: > create a news fragment with towncrier create . which will be included in the changelog. can be one...

Could you provide the output of ``pylint --version`` @behnazh-w, please ? @DarthLegiON I upgraded your example but we still miss the content of ``Base`` and ``RoleGroup``, would you mind providing...