pylint icon indicating copy to clipboard operation
pylint copied to clipboard

Add missing-timeout warning for ``requests.Session`` object

Open joel6948 opened this issue 10 months ago • 6 comments

some issue fixes https://github.com/pylint-dev/pylint/issues/9517 for this issue

joel6948 avatar Apr 01 '24 10:04 joel6948

Thank you for your contribution @joel6948, do you mind expanding missing-timeout instead of creating a new extension please ?

sure

joel6948 avatar Apr 01 '24 12:04 joel6948

Thank you for your contribution @joel6948, do you mind expanding missing-timeout instead of creating a new extension please ?

https://github.com/pylint-dev/pylint/pull/9527#issue-2218146584 done

joel6948 avatar Apr 01 '24 12:04 joel6948

You're also going to need to add a changelog entry, see:

create a news fragment with towncrier create <IssueNumber>. which will be included in the changelog. can be one of the types defined in ./towncrier.toml. If necessary you can write details or offer examples on how the new change is supposed to work. https://pylint.readthedocs.io/en/stable/development_guide/contributor_guide/contribute.html#creating-a-pull-request

Pierre-Sassoulas avatar Apr 01 '24 19:04 Pierre-Sassoulas

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 9f99786847edd23e9d52f07c928799df7b5da915

github-actions[bot] avatar Apr 02 '24 04:04 github-actions[bot]

@joel6948 Would you like to keep working on this?

DanielNoord avatar Jun 03 '24 20:06 DanielNoord

This PR needs take over because because it has been open 8 weeks with no activity.

github-actions[bot] avatar Jul 30 '24 02:07 github-actions[bot]

s PR needs take over because because it has been open 8 weeks with no acti

@joel6948 Would you like to keep working on this?

sorry for being late we can close this for now

joel6948 avatar Oct 20 '24 05:10 joel6948