Zoltán Lehóczky
Zoltán Lehóczky
I tried it, this is a runtime error. With both Elasticsearch and the client library being 8.18.2. https://github.com/elastic/elasticsearch-net/issues/8564 is now indeed fixed (I think), but we can't deserialize index settings...
The tests are super flaky now, so I'll wait for https://github.com/OrchardCMS/OrchardCore/pull/18044 and https://github.com/OrchardCMS/OrchardCore/pull/18043 to be merged before progressing here.
This looks like a bug indeed, so your workaround is what you need to do currently. Declaring dependencies in your module's manifest is recommended anyway if your module indeed depends...
Maybe we could add this to the docs?
The same is true for Razor templates in `.cshtml` files as well.
@pavel-mikula-sonarsource is this indeed completed, or did you close it because of the move? Asking because the latest release (https://github.com/SonarSource/sonar-dotnet/releases/tag/10.11.0.117924), published after this being closed, doesn't seem to contain it.
Please follow https://docs.orchardcore.net/en/latest/guides/contributing/contributing-code/#:~:text=If%20your%20PR%20addresses%20an%20issue%2C%20be%20sure%20to%20link%20them.%20This%20helps%20everyone%20find%20their%20way%20around%20contributions%2C%20and%20merging%20your%20PR%20will%20automatically%20close%20the%20issue%20too.
Not in a way explained in the docs :). You need to use something like `Fixes #15496` to make this PR close that issue, and show up under the issue...
Could you please create a separate issue about that, with specific suggestions?