Update Elastic.Clients.Elasticsearch to 8.18.3 and fixing the Blog Search recipes (Lombiq Technologies: OCORE-235)
Started from https://github.com/OrchardCMS/OrchardCore/pull/18038 but this needs manual fixes.
This also needed an Elastic.Clients.Elasticsearch fix: https://github.com/elastic/elasticsearch-net/issues/8577.
@MikeAlhayek can you please confirm https://github.com/elastic/elasticsearch-net/issues/8577?
This has to be tried for sure. I logged a bug with 8.18.1 which should be fixed in 8.18.2. To verify, create an Elasticsearch index using the Indexing module and see if it'll work or not.
I was planning to upgrade ES, but have not had time to do it. I'll try this PR out when I have chance this week.
https://github.com/elastic/elasticsearch-net/issues/8564
I tried it, this is a runtime error. With both Elasticsearch and the client library being 8.18.2. https://github.com/elastic/elasticsearch-net/issues/8564 is now indeed fixed (I think), but we can't deserialize index settings from the Entity now, so indexing is broken for our use case still.
You can reproduce this by running this code, and simply executing the Blog - Elasticsearch recipe after configuring Elasticsearch in appsettings.
The tests are super flaky now, so I'll wait for https://github.com/OrchardCMS/OrchardCore/pull/18044 and https://github.com/OrchardCMS/OrchardCore/pull/18043 to be merged before progressing here.
This pull request has merge conflicts. Please resolve those before requesting a review.
In the merge conflicts, ignore your changes to the .json files and take the ones in main.