OrchardCore icon indicating copy to clipboard operation
OrchardCore copied to clipboard

Update Elastic.Clients.Elasticsearch to 8.18.3 and fixing the Blog Search recipes (Lombiq Technologies: OCORE-235)

Open Piedone opened this issue 7 months ago • 6 comments

Started from https://github.com/OrchardCMS/OrchardCore/pull/18038 but this needs manual fixes.

This also needed an Elastic.Clients.Elasticsearch fix: https://github.com/elastic/elasticsearch-net/issues/8577.

Piedone avatar Jun 15 '25 21:06 Piedone

@MikeAlhayek can you please confirm https://github.com/elastic/elasticsearch-net/issues/8577?

Piedone avatar Jun 15 '25 21:06 Piedone

This has to be tried for sure. I logged a bug with 8.18.1 which should be fixed in 8.18.2. To verify, create an Elasticsearch index using the Indexing module and see if it'll work or not.

I was planning to upgrade ES, but have not had time to do it. I'll try this PR out when I have chance this week.

https://github.com/elastic/elasticsearch-net/issues/8564

MikeAlhayek avatar Jun 15 '25 22:06 MikeAlhayek

I tried it, this is a runtime error. With both Elasticsearch and the client library being 8.18.2. https://github.com/elastic/elasticsearch-net/issues/8564 is now indeed fixed (I think), but we can't deserialize index settings from the Entity now, so indexing is broken for our use case still.

You can reproduce this by running this code, and simply executing the Blog - Elasticsearch recipe after configuring Elasticsearch in appsettings.

Piedone avatar Jun 15 '25 22:06 Piedone

The tests are super flaky now, so I'll wait for https://github.com/OrchardCMS/OrchardCore/pull/18044 and https://github.com/OrchardCMS/OrchardCore/pull/18043 to be merged before progressing here.

Piedone avatar Jun 16 '25 15:06 Piedone

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Jun 16 '25 17:06 github-actions[bot]

In the merge conflicts, ignore your changes to the .json files and take the ones in main.

MikeAlhayek avatar Jun 16 '25 18:06 MikeAlhayek