Philip Loche

Results 25 issues of Philip Loche

## Expected behavior ## Calculating center positions like the center of mass in a periodic cell should take the periodicity into account. An edge case to test are two particles...

Component-Core
PBC

## Is your feature request related to a problem? ## Simulation cells in MDAnalysis (MDA) are defined via the `dimensions` attribute defining the cell via 3 lengths and 3 angles....

Partly Fixes MDAnalysis/waterdynamics#22 Changes made in this Pull Request: The `WaterOrientationalRelaxation` was restructured to follow the `start`, `stop` and `step` attributes of the `AnalysisBase`. The documentation was also improved and...

Component-Analysis

_Disclaimer: I thought there was an issue in the past with this idea but I was not able to find it. Sorry if the following idea is a duplication_ ##...

Component-Analysis

## Is your feature request related to a problem? ## As [discussed](https://github.com/MDAnalysis/mdanalysis/pull/3644#issuecomment-1100836585) in #3644 I am always frustrated when I see unsorted imports 🙃. Especially, for a new import, it...

maintainability
proposal

Fixes #919 Fixes #3651 Changes made in this Pull Request: * Deprecate `verbose` parameter in `AnalysisBase.__init__` (follows issue #3651) * Moved all docstrings from `__init__` function to class docstring (follows...

Component-Analysis

## Is your feature request related to a problem? ## The verbose option for Analysis classes appears in the `init` function and as well in the `run` method. The first...

## Is your feature request related to a problem? ## With the first version of the CLI released, we now would like to support more Analysis classes. This is especially...

Component-Analysis
proposal
GSoC
interoperability

When calling the `unwrap()` method of an `AtomGroup` the method correctly checks for existing bonds and raises an error if this is not the case. https://github.com/MDAnalysis/mdanalysis/blob/24abb160788ef87a48ed6eb196c1704d68fbc2da/package/MDAnalysis/core/groups.py#L1827-L1829 Even though the error...

usability
Component-Core
good-first-issue

Fixes #3569 The `AnalysisCollection ` follows the discussion of #3569 resetting the timestep object for each analysis by default. If requested the user can set the `reset_timestep` variable to `False`...

Component-Analysis