data_tamer icon indicating copy to clipboard operation
data_tamer copied to clipboard

Add thread-safe methods to add and remove data sinks in LogChannel

Open Basiljamal1 opened this issue 2 months ago • 1 comments

Summary

This PR aims to provide the ability to add and remove sinks from data channels at runtime. It introduces thread-safe methods for remove and add data sinks in the LogChannel class.

Impact

  • No breaking changes to the public API.
  • This update allows users to dynamically add and remove data sinks from a channel at runtime. This is especially useful for scenarios where data needs to be recorded/streamed temporarily on specific channels for short durations.

Please review the changes and provide feedback. :pray:

Basiljamal1 avatar Oct 21 '25 19:10 Basiljamal1

@facontidavide I think you should take a look at this PR too, in case I'm missing anything

henrygerardmoore avatar Nov 15 '25 22:11 henrygerardmoore

Sounds good, on it:)

Basiljamal1 avatar Nov 26 '25 15:11 Basiljamal1

Sounds good, on it:)

Great, thanks! Please re-request me when you're ready for a second review :smile:

henrygerardmoore avatar Nov 26 '25 17:11 henrygerardmoore