Philzen

Results 116 comments of Philzen

+1 This is a biggy for the CI config that i'm currently overhauling to test 14 project repositories under migration. All follow a consistent structure, so being able to have...

+1 This would make life much easier for us – and replace the need for a new user property as per https://github.com/jacoco/jacoco/issues/1291#issuecomment-1720297783

I have also tried `--no-type-check` as recommended in #1013 to no avail. Same as there `typescript-json-schema` works fine on the same file, however i do prefer the results from ts-json-schema-generator.

@domoritz There you go: https://github.com/Philzen/ts-json-schema-generator-bug-1790 I included both examples, just run `npm install` or `yarn` (tried both) and c&p any of the two example commands. Kindly reopen this issue once...

@domoritz Done: https://github.com/Philzen/ts-json-schema-generator-bug-1790/commit/78beea63270e4c7d951193462a4fd9a4fbcc008c

@domoritz As far as i can tell, not a single type can be removed from ’Validation’ – the type is composed from them and it was a considerable amount of...

Shouldn't the changes be done to [modules/openapi-generator/src/main/resources/JavaSpring/xmlAnnotation.mustache](https://github.com/chschu/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/JavaSpring/xmlAnnotation.mustache)? Looking at that file, i believe it would also be cleaner to include it as well at line 217 ... or even better,...

> The `xmlAnnotation.mustache` is responsible for the class-level annotations, so it cannot be used for the annotations on the getter. Of course, you're right, i missed that bit. > Having...

@chschu Happy to report i was able to whip up a basic test: https://github.com/Philzen/openapi-generator/commit/df55a9d1b61bada55fb20d7bbd8643e2fcdc1595 I would like to add some refactoring, then also fix the default Java generators and finally...

Note to self: Also add dedicated tests whether `xml.name` from `$ref`'d schemas is correctly applied (when it does, we have solved #5989 as well).