Philzen

Results 116 comments of Philzen

While finalizing this i briefly went through the other files – some of them i never looked at before b/c the stuff i initially wanted to fix in this PR...

Just a CI side-note: is there a reason i cannot see my changes in the netlify preview deploy? https://deploy-preview-6045--redwoodjs-docs.netlify.app/docs/tutorial/chapter6/comments-schema

> @Philzen You need to switch from v2.2 to Canary in the dropdown up top :facepalm: Duh, it's too hot. Thanks.

> There's some additional variables added to the `useEffect` on the Reset Password page...did you test this to make sure it didn't introduce any additional re-renders or anything weird? @cannikin...

I also recently contemplated about how to avoid templates producing code that violates linting rules, as this comes up over and over again. I can only assume currently there must...

@noire-munich I don't quite get what's up with this fixture check. I added an updated fixture and it still complains :shrug:

> ``` > yarn build:test-project --rebuild-fixture > ``` > > Have you tried that? Yeah i tried to avoid it b/c it takes ages and the CPU power of all...

Hmmm, now smoke tests are failing: ![image](https://user-images.githubusercontent.com/1634615/183778324-ba2472f0-d691-4ae5-b623-01e38914e00d.png) But this must be an unrelated general CI problem, i'm currently seeing this in my other PRs as well. Wonder if #6195 will...

:thinking: I don't quite get what to make out of this warning: ![image](https://user-images.githubusercontent.com/1634615/183938731-a10955e6-34d0-4f34-a0ee-9ec95c1b0ea6.png)

> I don't quite get what to make out of this warning: Duh, Multi-line comments can sometimes be confusing formatting-wise :facepalm: – fixed the leading space, should be fine now.