Phillip Barta comments

Results 100 comments of


                                            Phillip Barta

replace `mocha` and `nyc` with native node test runner and `c8`

Hey @blakeembrey, could you take a look at this and confirm if you're on board with the changes? Let me know if you have any concerns!

feat: add types

Hey @RobinTail, can you review again please? I implemented your suggestions.

feat: add types

Can we release this as a minor and recommend users to migrate away from `@types/finalhandler` to the built-in types, or would this require a major release?

refactor: use simplified `basename` function and remove dependency on `node:path`

@wesleytodd I understand your point. I thought about proposing [`pathe`](https://www.npmjs.com/package/pathe) which is used for example by Nuxt or [`unenv`](https://www.npmjs.com/package/unenv) but `content-disposition`s use case is so simple and only uses the...

refactor: use simplified `basename` function and remove dependency on `node:path`

Thanks for the feedback! > I think it is even supported there: [https://developers.cloudflare.com/workers/runtime-apis/nodejs/path/](https://developers.cloudflare.com/workers/runtime-apis/nodejs/path/) Just to clarify, `node:path` is only available in Cloudflare’s Workerd runtime when the `nodejs_compat` or `nodejs_compat_v2` flags...

fix: remove invalid engines field

@bjohansebas We have to options for the next release. Remove the emgines field and release v1.0.1 or publish v2

fix: remove invalid engines field

@UlisesGascon Has there been a decision from the TC?

chore(repo): updated husky to v9.1.5

CI Failure is unrelated to the change

cleanup(core): update @yarnpkg/parsers to a stable version

@FrozenPandaz Sorry for pinging you directly but can we get this merged for v20?

ci: add nodejs v18 - v24 to test matrix

> v23 is failing Please take a look at my comment