PhilippTakacs

Results 74 comments of PhilippTakacs

Can you provide a reproduction script?

It would be nice if you could provide a smaller example. I'm not familiar with your code.

This is the TCG buffer. Look at qemu/accel/tcg/translate-all.c Not sure if this is a real issue, because the memory is only allocated and not used (not sure how windows behaves...

The fix is only in dev, so you need to test with dev. I just have tested the PoC (export.zip) and got UC_ERR_INSN_INVALID. Looks like this is a problem of...

So after a bit testing the invalid instruction is at `0x10060` the code there (produced by the test case) is `0x116a1e3`. I can't disassemble this. When I look at the...

> > Hmm, aliasing, and later accessing, a `&mut Unicorn` borrow (via a raw ptr) is undefined behavior in Rust, AFAIK. I don't think the PR is sound as is(?)...

OK, I have understand this now, for the callbacks you create a raw pointer of self and add this to the user data of the callback. later in the callback-wrapper...

> > OK, I have understand this now, for the callbacks you create a raw pointer of self and add this to the user data of the callback. later in...

Hi Here is a patch which should work, based on code from https://github.com/drraid/unicorn/commit/b237335e6f2a321b7e2f4acf4ce7fdfe91fcd61f : ``` diff --git a/include/unicorn/unicorn.h b/include/unicorn/unicorn.h index 54ffd251..b9decb73 100644 --- a/include/unicorn/unicorn.h +++ b/include/unicorn/unicorn.h @@ -846,6 +846,14 @@...