Philip Nelson

That's fair, I have no idea what it would take to implement this. For anyone else looking for this feature, in vim `gqip` will format a paragraph and reflow it...

I know this is not exposed in harbor helm. The purpose of this pull request is to create a place to add environment variables.

What is the status of reviewing this feature? Is there something else that needs to be addressed? I don't mean to be annoying if it's still in progress, I'm not...

@zyyw are you able to look at this again? Is there someone else if you are too busy? Thanks!

@janesser is this what you are thinking? https://github.com/PhilipNelson5/harbor-helm/commit/5131b297fb94aff1391e66e00c411dac8620a152

Isn't this already possible with the current state of this branch with something like this? ```yaml core: containerEnv: - name: CONFIG_OVERWRITE_JSON valueFrom: secretKeyRef: name: harborSecrets key: configureUserSettings ```

It seems like the current version is more flexible. Is your intent to lock it down and force users to put the `CONFIG_OVERWRITE_JSON` string in a secret? I'm not opposed...

@janesser, ok I'm onboard. So the `core-dpl.yaml` would look like this? ```yaml {{- if .Values.core.configureUserSettings }} - name: CONFIG_OVERWRITE_JSON valueFrom: secretKeyRef: name: "{{ .Values.core.configureUserSettings }}" key: CONFIG_OVERWRITE_JSON {{- end }}...

> ```yaml > CONFIG_OVERWRITE_JSON: {{ .Values.core.configureUserSettings }} > ``` Do we want ` .Values.core.configureUserSettings` to already be base64 encoded or do we want to add this instead ```yaml CONFIG_OVERWRITE_JSON: {{...

@janesser of course. I was just waiting to hear about the b64enc to update the PR. I think this resolves everything we've talked about.