Phil Miller - NOAA
Phil Miller - NOAA
Other than the minor interface thing I noted, I'd approve this.
The reason I see the potential for retention is that the cleaning removes data from a particular past phase at a fixed offset from the current phase. if the model's...
Calling `setLoadModel` should be all that's necessary. Is cleanup not happening at all for `TestCol`, or is it just a phase behind or something like that? If the cleanup would...
Are the first two commits clearing up a first/second handler kind of situation? Why shouldn't a runnable be made and called there?
More deeply, do we need to maintain some notion of 'system mode' runnables that do all of the relevant instrumentation for occasions when we want to trace and account for...
Please squash the 'fix' commits into the commit they're fixing, for atomicity of evolution and review.
This generally looks good to me, even if only part of the code base is transformed to avoid copies and captures, and there's more to be done later.
> > More deeply, do we need to maintain some notion of 'system mode' runnables that do all of the relevant instrumentation for occasions when we want to trace and...
Without digging into what `git diff` output shows directly, is the code in the new `location.routing.impl.h` strictly cut and pasted from `location.impl.h`, or are there additional modifications in that same...
> Without digging into what `git diff` output shows directly, is the code in the new `location.routing.impl.h` strictly cut and pasted from `location.impl.h`, or are there additional modifications in that...