Philippe Castonguay

@axic Pretty please :D!

How could it round to zero? I haven't found a scenario where this could happen. @Agusx1211 (with the new divRound approach).

Right, I see, though if we changed that, the owner of the 500 initial liquidity tokens would lose some, as per https://github.com/arcadeum/niftyswap/issues/19. For instance, User A adds 1 token (and...

One can't replace `msg.sender` with `_from` for the `_operator` since the operator is not always "from" and is meant to represent who initiated the transfer. A dex could be the...

Indeed. I discussed with other ERC-1155 devs and we agree that this is a bit subjective and what `operator` might represent could vary. Need to ponder this a bit more.

Good catch! Changed the comment to say `integer` instead of `hex` because of how the URIs are returned by that function, the `_uint2str()` does keep the integer format. To return...

I'm hesitant with this suggested fix, because when one assumes that a malicious dapp can make sign arbitrary transfer data, then the amount of harm they can do goes beyond...

I guess the definition of what an operator is is quite unprecise. - If Bob calls a contract C that transfers Alice's tokens, is contract C (msg.sender) the operator or...

Not with the exact ABI of these contracts. We could deploy one if that would be helpful for you @fulldecent !

This repository is meant to be an NPM package that gets consumed by other devs contract who will have their our migration system. https://www.npmjs.com/package/multi-token-standard