Phoenix Himself
Phoenix Himself
@Mte90 I think that this PR might be closed once we implement the new numeric system (one that does not use `bc`)
I'm closing this PR for until we introduce better numerical system
`set -x` enables the Bash debug mode where all executed commands are printed to the terminal (standard error) after being expanded but before being executed. This could be turned on...
I think that this is the moment when we should add that optimization I explained before: https://www.youtube.com/watch?v=_caXIMxrYj8&feature=youtu.be This would solve this issue too.
I'm thinking... can we insert some kind of runtime detection for removing some directories like `/`, `~`, `/bin`, `/sbin`, `/dev`, `/etc`, `/usr` etc. To prevent this command from running -...
@b1ek @KrosFire What do you think?
Okay. My stance on this is that if this builtin is destructive (dangerous) then let's keep it as a function library. I'm closing it and will update the built-in guidelines....
I'll approve once @hdwalters confirms that these changes work on Windows GitBash too
@Mte90 the POSIX version is supported by Bash and SH. Migrating to the POSIX version will not affect the existing bash compatibility
@Mte90 it's right here: https://github.com/amber-lang/amber/blob/2e34e15da2654f57ef17ecef4342b01f1e3ea0b6/src/modules/function/declaration.rs#L257