Phoenix Himself comments

Results 280 comments of


                                            Phoenix Himself

✨ Generated script readability

Bash Scripts are running on personal deveices thus it's important for people to let them review it's contents and see what the script is doing.

[BUG] Incorrect Boolean Casting

Is it a valid cast though? The cast from `Text` to `Number` is marked as "absurd". The same should apply to `Text->Bool`. - [ ] A warning should be appeared...

[Suggestion] Change error message: Failed expression must be followed by a block or statement

The line that gets produced in the error: ``` [src/modules/condition/failed.rs:64:21] "FAILED" = "FAILED" ``` Is removed once this PR gets merged https://github.com/Ph0enixKM/Amber/pull/203

[Suggestion] Change error message: Failed expression must be followed by a block or statement

@Mte90 Which PR closes this issue?

[Suggestion] Change error message: Failed expression must be followed by a block or statement

This only partially closes this issue - we need to change the error message too

Remove sed for condition

@Mte90 but the `scale` parameter gets rid of the fraction part in the number

Remove sed for condition

@Mte90 there are some tests that were added but are not on this branch. Can you `git pull origin master`?

Remove sed for condition

@Mte90 This PR has many tests failed

Remove sed for condition

> ``` > #!/usr/bin/env bash > # Written in [Amber](https://amber-lang.com/) > # version: 0.3.4-alpha > # date: 2024-08-09 11:26:27 > > function foo__0_v0 { > local a=$1 > local b=$2...

Remove sed for condition

@Mte90 What does this PR actually do? Do you want to remove the usage of `sed` inside of relation operators like `>`, `=`, `