PgBiel

Results 402 comments of PgBiel

> I agree for stroke, but disagree for color because it's really an enum and having the `values` with different values and unclear interpretation is weird to me. It's not...

> > Perhaps we could repurpose the to-rgba/cmyk methods to just return an array of values instead > > I thought they already did! Haha, they did that before, but...

@laurmaedje the PR seems to be mostly complete now. What's truly missing is **documentation**, and, for that, there are two blockers (I've added what I could so far though): 1....

> Currently `stroke`, `direction`, `alignment`, and `alignment 2d` link to some function they are often used with. An extra type page would be okay I guess, I didn't do it...

Alright, I believe I've added docs for everything now. All that's left is mostly reviewing stuff, adapting docs as needed, etc. I'll be undrafting the PR then, since the main...

Hey, thanks for the PR! Just wanted to share some thoughts: could it perhaps be better or clearer to use a function named something like `mid` (similar to LaTeX) for...

> It feels a bit inconsistent to me that term lists are excluded from this change. I see why (they work), but maybe they should be handled the same? I...

Just to complement this, upon my tests (see https://github.com/PgBiel/typst/commit/0630afcb43f55aefbdc5096411368c1b58435e96), simply changing the children field to a vector of `Content` does not work for TermElem. It still requires a separate element...

> Makes sense, sorry for the oversight on my part! Oh, please, no worries! We're all working towards a common goal here ;)

Hmmm, @laurmaedje I agree this would be a problem. I see three options here: 1. Place this PR on hold until the style rework happens (not sure if that would...