PgBiel

Results 402 comments of PgBiel

Sorry to hear that, it went under our radar. This seems similar to https://github.com/typst/hayagriva/issues/259

Indeed, `archive-url` is not a supported field - the list of supported fields can be found at https://github.com/typst/hayagriva/blob/main/docs/file-format.md. CSL doesn't have a variable for an archive URL specifically (see https://docs.citationstyles.org/en/stable/specification.html#standard-variables)....

Note that CSL has other title kinds, so Hayagriva has to decide which to use. In the reference case, I believe `volume-title` should work based on the code. https://github.com/typst/hayagriva/blob/799cfdcc5811894f62949a63b155878e2f30b879/src/csl/taxonomy.rs#L384-L396

Well, I suppose the error is correct, we can't really parse that year. But maybe this is some special syntax to indicate actual value vs how it should be displayed?...

Good eye, it seems we sort before assigning the suffixes. Though it appears we also determine some other properties later. I wonder if the sort could influence this, or if...

> I tried adding it to the citeproc.rs, but tests there don't seem to run via cargo test. You need to enable the `csl-json` feature (see CI).

No, just naively sorting again probably breaks citation numbers. I'm not sure why this doesn't appear to be explicitly tested at the moment, though it can be manually tested (either...

Thank you for the contribution. For the time being, I'll consider this blocked on upstream (CSL schema). I'll note however that I've seen some styles which seemed to use some...

I can see the value in having something like that, but I would hold off from adding this for now. Hayagriva's format so far has attempted to be fairly independent...

I'll note that we take our styles from https://github.com/citation-style-language/styles/, so it's possible it's an issue with the APA style provided there. With that said, I've done some local tests and...