Peter Johnson
Peter Johnson
Duplicate of #4041?
Some of our settings popups are *very* complicated, e.g. those for Field2D and plots. It would be nice to be able to tweak settings while seeing what the results are....
I don't think `CreateCommand` is any better than `std::make_unique`. A better sugar would be e.g. `InstantCommand::Create(...)` instead of `std::make_unique(...)`.
0004: The libuv wrappers and uses of them benefit from having a bit more space for captures to avoid memory allocations... I think I actually did some testing on this...
Theoretically NOMINMAX could break other libraries teams pull in.
> I assume a corresponding docs PR will be opened? Yes, I'm working on it, but getting this merged is higher priority as it has ripple effects on vendors (ABI...
Will this silently break a lot of team code?
Untested with actual joysticks, but it appears to be: `enum { X, Y, Z, Rx, Ry, Rz, Slider, POV, None }` Where Slider and POV are device specific: 0. X-axis,...
The selectRunFromDisabled test in new commands is consistently failing with this PR. https://github.com/wpilibsuite/allwpilib/blob/main/wpilibNewCommands/src/test/java/edu/wpi/first/wpilibj2/command/RobotDisabledCommandTest.java#L150
If you write a big switch statement, the compiler will do most of the work for you. But I agree that it might be more expensive than you might want...