Peter Hickey

Results 174 comments of Peter Hickey

FWIW I've deprecated (BioC 3.18) and made defunct (BioC 3.19) the implementations of `colAnyMissings()` and `rowAnyMissings()` in **DelayedMatrixStats**. It never had a `anyMissing()` implementation. We opted to not implement `colAnyMissings()`,...

FWIW `scuttle::makePerCellDF()` and `scuttle::makePerFeatureDF()` by @LTLA does something similar for _SingleCellExperiment_ (_SCE_) objects, albeit returning a _data.frame_ (because these functions are typically used for creating custom **ggplot2** plots). These functions...

Thank you, @jackgisby, for your explanations. I haven't yet started my review, but I will have it for you within 3 weeks (usually sooner). Cheers, Pete

Hi @jackgisby, Thank you for submitting **ReducedExperiment** to Bioconductor. I've completed my checklist review of **ReducedExperiment** below and I have separated the issues into **Required** and **Recommended** points that I...

Hi @jackgisby, I am on leave for the Christmas / New Year break where I work, so please don't expect a reply from me until after I return to work...

Thank you for your considered and detailed reply, @jackgisby. I'll reply properly in the next few days to continue the review.

Hi @jackgisby, Thank you making the required changes, considering the recommended changes, and for including a summary of where **ReducedExperiment** fits in with existing Bioconductor packages in the vignette. I'm...

Thanks, @jackgisby!

Hi Jayaram, Testing with the [example I gave earlier](https://github.com/kanaverse/kana/issues/264#issue-3119806472) gives the following error ![Image](https://github.com/user-attachments/assets/d2c78edd-809e-4849-a20e-34b7e775cb1c) with log ``` 12:43:06: (downloadsdb) store initialized 12:43:07: analysis state created 12:43:07: bakana initialized 12:43:11: preflight_input...