Pete Gillin

Results 18 comments of Pete Gillin

When you talk about `Map.get`, you're talking about the return type, I guess? Because there's also a slight question mark over the parameter type: the spec allows `get(null)` to NPE,...

One method that I think should be added to the list for this issue is `Thread.getUncaughtExceptionHandler()`, which returns null but only if the thread has terminated. In Android, I made...

I think there's been some miscommunication. Android, AFAIK, does indeed declare `@Nullable V get(@Nullable Object)`. I don't think we consider ourselves special in this case. I know that there are...

For what it's worth, I am currently only +0.5 on my own proposal. The more I looked into it, the more API surface I discovered that it would have to...

Yeah, I added the support for floating point arrays (`PrimitiveDoubleArraySubject.usingTolerance(...)`) and iterables (`IterableSubject.comparingElementsUsing(tolerance(...))`) but the support for single floating point values (`DoubleSubject.isWithin(...)`) had been around for a long time before,...

That might be fun, indeed. (I would suggest doing the experiment with `isWithin` rather than `usingTolerance` as you'll hit far more cases. And, indeed, doing it with `isNotWithin` could be...

First of all, I haven't looked at the googletest implementation, and I'm not even sure exactly what "within four ULPs of one another" means. If x and y are not...

P.S. There are some things in [DoubleUtils](https://github.com/google/guava/blob/master/guava/src/com/google/common/math/DoubleUtils.java) that might help with the impl.

(Actually, I suppose it's possible that the meaning of "within four ULPs of one another" when ULP(x) != ULP(y) _is_ exactly the mix of the two ULPs that corresponds to...