person93

Results 24 comments of person93

Does the debugging have to be through normal CLI output? Perhaps add a feature flag that enables a GUI that lets you see the output and step through the parsers....

I was thinking more about locality then allocation time, but I might be guilty of premature optimization here. To you point about not harming the average user, you can add...

I added a commit to fix a security vulnerability, but I forgot that I'd used this branch for a pull request. If you re-run the CI job it should pass...

> Give the user control over date and version formatting > > * e.g. having an example Cargo.toml that only lists major+minor rather than the full version You can do...

> > What should happen if running git rev-parse HEAD to get the release commit fails? It should probably exit non-zero, but I see that you use specific exit codes....

> What if we provide the tag instead? I added [this function](https://github.com/Person-93/cargo-release/blob/e50cb1a31aa1868be44cc363b9eb21592b06c110/src/git.rs#L124-L131) which gets the head sha. I'm not sure what to do if it fails.

> Forgot to publish these ??

> Oh, have you looked at how other release processes from other ecosystems deal with this? I'm assuming there is similar for node and others. We should make a list...

I've made the changes we discussed and added two failing tests. The hook does not run. I tried to copy the same logic that determines when to run the pre-release...

I've made the changes we discussed and added two failing tests. The hook does not run. I tried to copy the same logic that determines when to run the pre-release...