Yu Yihuang
Yu Yihuang
> With this implementation, there are two different sets of logic that can change the same device configuration. I think it's going to be a little confused. But yes, the...
> Okay, If those virtio devices which show iommu_platform in help info but does not support it actually, how do you think about defining blacklist for them ? I thought...
> I think it is same for test case level to handle `xxx_extra_params`, when new virtio device be introduced and have the same problem, case need be updated accordingly IMO,...
@yanan-fu updated according to our offline discussion, I think these are the minimal changes based on the conversation.
Test: ```python >>> import re >>> devices = [{'dev': 'virtio-net-pci'}, {'dev': 'vhost-vsock'}, {'dev': 'pxb-pcie'}, {'dev': 'virtio-balloon-pci'}, {'dev': 'virtio-iommu-pci'}, {'dev': 'vhost-user-fs-pci'}] >>> virtio_dev_filter = '^(?:(?:virtio-)|(?:vhost-))(?!(?:balloon)|(?:iommu))' >>> list(filter(lambda x: re.search(virtio_dev_filter, x.get('dev')), devices))...
Re-push to fix the CI failure.
Hello @vivianQizhu, could you also help to review?
@pevogam, good point. Actually I never test floppy devices, but if it was introduced very early, I think we can re-design this part directly. Replace it to use `QPCIBus` should...
Please modify the cfg name to include `nic`, such as `hotplug_unplug_nic_with_viommu`.
Please refer to https://avocado-framework.readthedocs.io/en/99.0/guides/contributor/chapters/styleguides.html#commit-style-guide to update your commit style.