tp-qemu icon indicating copy to clipboard operation
tp-qemu copied to clipboard

virtio_mem_numa_basic: new auto case for basic numa test with two virtio-mem devices.

Open mcasquer opened this issue 3 years ago • 10 comments

Depends on https://github.com/avocado-framework/avocado-vt/pull/3510

virtio_mem_numa_basic: new auto case for basic numa test with two virtio-mem devices.

Creates a new case that boots up a guest with two numa nodes and two virtio-mem devices, it resizes several times the virtio-mem devices and checks its sizes.

ID: 2121669 Signed-off-by: mcasquer [email protected]

mcasquer avatar Sep 14 '22 13:09 mcasquer

@yanan-fu could you review this PR? Thanks!

mcasquer avatar Sep 15 '22 06:09 mcasquer

Refactorized the test code and extracted the functions to a provider file

 (1/1) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.2.0.x86_64.io-github-autotest-qemu.virtio_mem_numa_basic.q35: STARTED
 (1/1) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.2.0.x86_64.io-github-autotest-qemu.virtio_mem_numa_basic.q35: PASS (481.51 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

mcasquer avatar Nov 16 '22 15:11 mcasquer

@yanan-fu @zhenyzha could you review this PR? Thanks!

mcasquer avatar Nov 16 '22 15:11 mcasquer

@zhenyzha @yanan-fu could you review again this PR? Thanks!

mcasquer avatar Nov 22 '22 12:11 mcasquer

After the case modifications:

 (1/1) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.2.0.x86_64.io-github-autotest-qemu.virtio_mem_numa_basic.q35: STARTED
 (1/1) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.2.0.x86_64.io-github-autotest-qemu.virtio_mem_numa_basic.q35: PASS (416.22 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

mcasquer avatar Nov 22 '22 13:11 mcasquer

git am 3479.patch Applying: virtio_mem_numa_basic: new auto case for basic numa test with two virtio-mem devices.

(1/1) Host_RHEL.m9.u2.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.2.0.aarch64.io-github-autotest-qemu.virtio_mem_numa_basic.arm64-pci: FAIL: Error, size: 83886080 and requested-size: 0 are not equals. (174.40 s)

Failed since of product issues. LGTM.Acked-by: Zhenyu Zhang [email protected]

zhenyzha avatar Nov 25 '22 03:11 zhenyzha

@PaulYuuu could you review again this PR? Thanks!

mcasquer avatar Nov 28 '22 11:11 mcasquer

@yanan-fu @PaulYuuu @zhenyzha please could you review this PR again? thanks!

 (1/1) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.2.0.x86_64.io-github-autotest-qemu.virtio_mem_numa_basic.q35: STARTED
 (1/1) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.2.0.x86_64.io-github-autotest-qemu.virtio_mem_numa_basic.q35: PASS (375.10 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

mcasquer avatar Nov 29 '22 08:11 mcasquer

(1/1) Host_RHEL.m9.u2.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.2.0.aarch64.io-github-autotest-qemu.virtio_mem_numa_basic.arm64-pci: FAIL: Error, size: 117440512 and requested-size: 0 are not equals. (182.89 s)

The result is as expected, ack.

zhenyzha avatar Nov 30 '22 06:11 zhenyzha

@yanan-fu @PaulYuuu could you review this PR again? Thanks!

mcasquer avatar Dec 12 '22 08:12 mcasquer

Please refer to https://avocado-framework.readthedocs.io/en/99.0/guides/contributor/chapters/styleguides.html#commit-style-guide to update your commit style.

PaulYuuu avatar Dec 13 '22 15:12 PaulYuuu

Please refer to https://avocado-framework.readthedocs.io/en/99.0/guides/contributor/chapters/styleguides.html#commit-style-guide to update your commit style.

@PaulYuuu commit message updated according the rules.

mcasquer avatar Dec 13 '22 16:12 mcasquer

@PaulYuuu after talking with @yanan-fu she agrees with merging the patch with the current approvals because she's not feeling very well today, so feel free to merge this whenever you want

mcasquer avatar Dec 14 '22 07:12 mcasquer