Paul Licameli

The latest push looks good, but it awaits completion with step 5. A few comments: - `VSTEffectValidator::mIntance` might be private. - I was surprised to see `AudioMaster` moved into `VSTInstanceBase`....

> > * Why is `mTimeInfo` still in the Effect class? Only the Instance and the slaves, also Instances, need it. Once you address the point about `ProcessBlockB`, this will...

> > > * Why is `mTimeInfo` still in the Effect class? Only the Instance and the slaves, also Instances, need it. Once you address the point about `ProcessBlockB`, this...

> I was wrong when I said that Automate has to belong to the instance. It must indeed belong to the Effect, because changes in sliders are intercepted by the...

I am reviewing the latest force-push and so far I am satisfied with the 4.x steps. They can be squashed into one in your next force-push.

Please rebase onto latest master, squash steps 4 into one, and squash steps 5 into another commit. Address in step 5 the two reqeusts for change. Then, this will be...

Less important, `mUseLatency` might also move from Wrapper to Instance

But if there are action items to re-list those effects as bad ones, then put this back into to-do.

Commit d7c160a00d38003530ab9f133b3c56c79c2c2277 has restored the black list

However what is essential is that the dialog, as opened from the sidebar, contains *some* play button. But in fact is has none now. This leaves you no way to...