Paul Licameli

Results 172 comments of Paul Licameli

> I am getting an exception thrown on Windows, since the third commit [9781cdd](https://github.com/audacity/audacity/commit/9781cdd07efb967e218c72b2d193caae4f08dc36) ("RealtimeEffectManager::Process is given enough buffers...") by doing the following: > > 1. generate 1 second of...

I have made an alternative fix to Dmitry's, which is surprisingly simple, though I took some wrong turns finding it.

Have an always visible play head, distinct from the selection, and it almost becomes obvious. But note that when our play head is visible and pinned, click and drag is...

> > But note that when our play head is visible and pinned, click and drag is already used for something: moving the pin. It can be more useful to...

In my fetch of your latest force-push, there is still failure to build on macOS at the second commit.

"removed unnecessary calls to ResetModuleAndHandle" might be squashed earlier

> Please note: "effect inherits PerTrackEffect not StatefulPerTrackEffect" is specified originally as part of step 4; but once I changed that inheritance, the code would not build until I implemented...

I wrote earlier "Also in step 4, the PowerOn() in BuildFancy() should be changed to call it on the Instance, not on this. Pass the Instance into BuildFancy() from PopulateUI()."...