Paul Licameli

Results 172 comments of Paul Licameli

At least on a macOS debug build with the effect I named, I can reproduce this regularly.

I'm looking over the sum of changes in the squashed sequence of commits, and there are few things to addres. - Remove mParentFE and just use null instead for the...

There was one build failure, but maybe spurious. I restarted it to be sure the branch so far is OK. As I said, if you address my few recent comments,...

`FetchSetingsFromInstance` may be inappropriate for VST. The analogy with AudioUnits may be the wrong one to follow. I'm looking at `VSTEffectValidator::ValidateUI()` and wondering what's the next step. Remember how this...

> This is even more important now that the "Cancel" button has been removed from Effect dialogs. Some interfaces just don't give you explicit save and cancel buttons. For instance,...

> I have a very strong opinion, that cancelling a drag and reverting a bunch of operations is a very different thing. Consider a text editor, that silently closes on...

> I understand your suggestion well. This an editor that closes without warning. It should be clearly shown to the user, that he will lose part of the changes. Which...

But then, one could hit either Enter or Esc very easily to dismiss the dialog one way or the other.

But also apart from the question of reversion of settings: with no keystroke to dismiss the dialog, is that acceptable for accessibility? @DavidBailes

But this should also be tested: does the plug in work in Audacity 3.1.3 for destructive processing?