Raj Patel

Results 8 comments of Raj Patel

@JordiParraCrespo Can you rebase this branch to the latest `main` branch? Then we are good to merge.

@JordiParraCrespo You will need to sign your commits before this PR can be merged.

@achaljhawar Thanks for the PR! In continuation of https://github.com/XRPLF/xrpl.js/pull/2985#issuecomment-2946178746 it would be useful to do the following: 1. Have a separate Github action workflow for Faucet tests that are executed...

@achaljhawar There are conflicts in `packages/xrpl/test/integration/fundWallet.test.ts`. Please merge in the latest main branch to fix them. I'll have a look once those are resolved.

@achaljhawar Commits must be signed before we can merge the PR. Can you enable signing at your end and sign the commits and force push?

@khancode In xrpl.js `VaultDeposit` and `VaultWithdraw` transaction's `Amount` field is not supporting MPT's. I think it should support as per the spec.