Astraea Quinn S

icon company Huawei Munich Research Centre icon location Munich icon location Senior software Engineer @ Huawei Dresden Research Centre

Results 61 comments of Astraea Quinn S

Fix FP in `threadlocal!` when falling back to `os_local`

Thank you Alejandra I appreciate your time and effort! I found another case I hadn't considered initially, and will add that with the changes.

Fix FP in `threadlocal!` when falling back to `os_local`

If this is fine, maybe we can merge this to bundle it with the release?

Fix FP in `threadlocal!` when falling back to `os_local`

Done, thanks! ☺️

Add documentation on trait checking and type construction

Thanks! I will fix it later today ☺️

needless_lifetimes wrongly detect elidable lifetime with Iterator

@rustbot claim

needless_lifetimes wrongly detect elidable lifetime with Iterator

The problem with this lint is with the collection of lifetimes within the "inner" types.

Clippy `contains_key` followed by `insert` suggestion won’t compile

@rustbot claim

Suggest removing `filter_map` for `Iterator::filter_map(|x| Some(x))`

You may use `@rustbot claim`

Most time consuming test files

I'd like to look around `filter_map_*`s if that's okay.

Complete and fix our eventfd implementation

Hey @RalfJung I would like to give this a shot. May I just `@rustbot claim` it?