Astraea Quinn S

@saethlin This is unfortunately beyond my skills at the moment. Please take it away if you want.

Is that machine applicable? I was thinking that removing `Some` for `Option` means that it can't be followed by a `map` with closure `Option -> T`, so we can't replace...

I don't think this is a clippy bug, but more like an enhancement?

@rustbot claim Assigning this to me as I am working on the sibling issue.

This should be under `unnecessary_filter_map`, and should not be treated as a special case of `filter_map_identity`. This should be straightforward; Introduce a check in `unnecessary_filter_map` to see whether the closure...

The `boxed_local` ones need a minor change on their lint message and are good to go.

My concern is that it would create false positives, and potentially allow bad code compilation, eg parsing bad postgresql code and then compiling that back in the wrong order. I...

I accidentally created such a bug and the only reason I caught it was because my condition was `_ => if ...` and not `(_, 1) => if ...`, and...

Right the suggestion will introduce more errors. Could we limit it to just a warning and suspicious?

But that's not the same, is it? the intention is basically to disallow `pat => if` and `pat => { if ... {rest} }` and instead recommend `pat if ......