Results 270 comments of Pankraz76

> Yes its impossible to review this of course, as we have countless flaws, which is the natural outcome, when not having auto correction like this. Nobody can to this...

Its all related and spot the solution to all: - https://github.com/pmd/pmd/issues/5848 - https://github.com/pmd/pmd/issues/5850 - https://github.com/pmd/pmd/pull/5845 - https://github.com/pmd/pmd/pull/5776 > - https://github.com/pmd/pmd/pull/5776 considering this a good PoC and realistic to merge. Then...

> **pre-commit setup** This could be complex, as Spot takes some time, while committing is a fast and frequent task. Assuming every commit would then somehow execute `mvn spotless:apply`. Despite...

maven does not apply auto fix on cloud like expected: - https://github.com/apache/maven-parent/blob/f4ab7c2eb04865071186c57a263243c72b6e8d52/pom.xml#L1415C11-L1415C30 - https://github.com/apache/maven-parent/blob/f4ab7c2eb04865071186c57a263243c72b6e8d52/pom.xml#L1419 in gradle its one simple if and its done: its differently executed, the result is always...

> @pankratz76 Thanks for your enthusiasm, but bumping the java version is always a change, that breaks major compatibility promises we made. Please discuss such efforts before spending too much...

Thanks for incorporating. It would be nice if this checker is generic. There are different API´s to avoid: > * `new URL(url);` -> > * `URI.create(url).toURL();` > * `new Locale(localeLanguage,...

This is very arguable and a highly breaking change for very little benefit, so it's just a point of discussion. I'm aware of the low priority of this request.

Thanks for the reply. Then maybe consider going fully rockstar mode adapting both using `"common"` `include,exclude` naming, as this is kind of what it is, right? [Whitelist/Blacklist](https://cyber-curriculum.com/Begriffslexikon/whitelist-blacklist/) The latin phrase...

> From the issue description and ensuing discussion here, it is not 100% clear to me whether we are talking about just ImportControlCheck, or naming conventions in general. yes valid...

Ideally, an API should speak for itself: + It requires time to understand/resolve the abbreviation `pkg`. + For the sake of (the/new) users, we might want to elevate this too....