Gavin John

Results 803 comments of Gavin John

> Why isn't it possible to use the squash when merge option? It's not enabled on this repo, and it's really not hard to just interactively rebase.

Shizuku is now licensed under Apache-2. I suggest this or #55 be reopened

Nice! I don't really have the time to to thoroughly test this right now, but this _looks_ sane and is a welcome improvement (if it works, of course).

The diff lgtm, so I'll go ahead and merge this. If this causes any failures, I'll just revert it.

Reviewed the LICENSE; it seems that it hasn't been correctly applied, since the notice hasn't been completed. ``` APPENDIX: How to apply the Apache License to your work. To apply...

Never mind, I'm stupid. It means to apply it to the source files, not the LICENSE itself.

The indentation seems to be mismatched. EDIT: I just saw https://github.com/wb2osz/direwolf/issues/573; might be worth just keeping the indentation of the line immediately preceding it?

Weird. I use vscodium and if anything it doesn't mess with the indentation when it should. Definitely there should be a consistent indentation style throughout though; that is pretty obviously...

+1 for adding this under the name `Not-Copyright-Eligible`. For my REUSE projects, I've had to stick to CC0-1.0 for files I believe to be, well, not copyright eligible. This is...