Gavin John

Results 803 comments of Gavin John

Can Repro: ![image](https://user-images.githubusercontent.com/45835846/160493614-fec339b7-de31-464f-b6df-5b8ad1bf3596.png)

I've submitted a PR at https://github.com/MetaMask/metamask-extension/pull/14233. It got locked by mistake though.

Personally, I wouldn't approve it because the standard would have to be brought up to current EIP formatting (and that involves non-normal changes). Alternatively, this could be manually merged. @MicahZoltu...

> I have not changed any text or normative things. I think you have normative vs non-normative flipped around: Normative: the meaning is unchanged. Non-normative: the meaning is changed. The...

Sorry, let me be a bit more specific: Some of the changes required by eipw here _require_ non-normative changes to the spec.

ERC also needs to be replaced with EIP.

> 173 is FINAL, I lean towards follow IETF RFC approach to create a new EIP that "updates" EIP-165 This doesn't introduce any backward incompatibilities and is therefore fine.

> This PR does not touch any mention of "ERC" or "EIP". `eipw` still requires that you fix the instances.

> I suggest EIPW to be updated so that it only check modified lines rather than full file. If the effort to bring an EIP up to date is not...