Peter van der Woude

Results 38 comments of Peter van der Woude

Just a friendly interjection, I think replacing all the tests with a different framework should be separated into a different PR. Also moving to .NET Core 2.0 is not just...

Yeah support for the Deployment API (used to interact with ClickOnce version info) is completely removed in .NET5 and I can't see any way to provide a backwards compatible migration...

PS The DeploymentAPI I referred to is in ReportGenerator.cs (line 47 right now) It requires a reference to `System.Deployment.Application` ``` private string GetAppVersion() { return ApplicationDeployment.IsNetworkDeployed ? ApplicationDeployment.CurrentDeployment.CurrentVersion.ToString() : _info.AppAssembly.GetName().Version.ToString();...

Hey, yeah I wish that code could work - the only problem I think I had from there is including a reference to the `System.Deployment.Application` assembly - I think I...

Thanks for that, I'll have another try, based on your help/links and see if I can get any further.

Maybe this was setup at some other time as I see the "key.snk" file in the [src](https://github.com/PandaWood/ExceptionReporter.NET/tree/master/src) folder

I read recently the best advice on this is to strong name open source assemblies - taking this article as advice, I would like to to do it. Just ensuring...

Thanks yeah, I should pull in the netstandard2 PR from SimpleMAPI first and then come back to this one

I noticed a lot of people are missing the `ApplicationDeployment` API in Net5, they're tracking the issue here (we use it twice in ER) https://github.com/dotnet/deployment-tools/issues/27 One user's solution is [this](https://github.com/derskythe/WpfSettings/blob/master/PureManApplicationDevelopment/PureManClickOnce.cs)...

Actually, reading this MS blog, I get the idea that the most practical option here is to target .netstandard 2.0 - to basically support both .NetFramework and .NET5 https://devblogs.microsoft.com/dotnet/the-future-of-net-standard/ `If...