FALCON_unzip icon indicating copy to clipboard operation
FALCON_unzip copied to clipboard

poor shutdown/restart handling with partially written files

Open flowers9 opened this issue 9 years ago • 1 comments

There are places in get_read_hcgt_map.py (1), phasing.py (6), run_quiver.py (1), and unzip.py (1) where the code checks to see if output files from earlier parts are present before running subsequent parts. However, it doesn't check to see if those are files were finished being written to, merely present, and the code that writes those files doesn't have any way of signaling partially writen files. So it's quite possible, should the run be interrupted for some reason, for a restarted run to read partially written files and attempt to process them as if they were complete.

The straightforward solution is to write the files to a temp file, and then rename them after they're complete and closed.

flowers9 avatar Jul 29 '16 14:07 flowers9

Unnecessary. Use done files. Good point though.

pb-cdunn avatar Jul 29 '16 15:07 pb-cdunn