px4_ros_com icon indicating copy to clipboard operation
px4_ros_com copied to clipboard

Published 20 hours ago • verified publisher icon PX4

Offboard example in Python3

Open TheLegendaryJedi opened this issue 3 years ago • 4 comments

To build I needed to add a new folder with a empty __init__.py

TheLegendaryJedi avatar Mar 25 '21 15:03 TheLegendaryJedi

Cool work, thanks, it made my life much simpler as I did not have to convert the C++ example to Python!

Some suggestions:

  • would be cool to show a way to make some fields of TrajectorySetpoint ignored, e.g., msg.x = float("NaN"). It took me a couple of hours to figure this thing out. Alternatively, would be cool if None could also be interpreted as NaN or the default value is NaN.
  • I'm not sure the comment in the documentation about changing execution rights for the script is needed, they seem to be set correctly in git.
  • This commit is a bit confusing to me, seems unrelated to this PR: https://github.com/PX4/px4_ros_com/pull/74/commits/f954785175cb97e1267daf5478326608b36707d8

If there is anything I could do to help with this PR, please let me know, I'd be happy to help!

zeroos avatar Apr 13 '21 08:04 zeroos

Cool work, thanks, it made my life much simpler as I did not have to convert the C++ example to Python!

Some suggestions:

  • would be cool to show a way to make some fields of TrajectorySetpoint ignored, e.g., msg.x = float("NaN"). It took me a couple of hours to figure this thing out. Alternatively, would be cool if None could also be interpreted as NaN or the default value is NaN.
  • I'm not sure the comment in the documentation about changing execution rights for the script is needed, they seem to be set correctly in git.
  • This commit is a bit confusing to me, seems unrelated to this PR: f954785

If there is anything I could do to help with this PR, please let me know, I'd be happy to help!

Thanks a lot for the contributions!

Yes, that commit is nothing related to this PR.

If you want, after merged, you can edit it and add those comments regarding the "NaN" and submit a new PR.

Thanks!

TheLegendaryJedi avatar Apr 13 '21 14:04 TheLegendaryJedi

Any progress on this? I ask because of the associated docs PR :-)

hamishwillee avatar Jun 17 '21 01:06 hamishwillee

Any progress on this? I ask because of the associated docs PR :-)

I don't know if it's good to merge (just the 09b5a07). @TSC21 can you review it?

TheLegendaryJedi avatar Jun 25 '21 08:06 TheLegendaryJedi