flight_review icon indicating copy to clipboard operation
flight_review copied to clipboard

Automate image build for docker-compose

Open bbworld1 opened this issue 4 years ago • 2 comments

The px4flightreview image does not exist until you build it manually, meaning the docker-compose config will not launch until you build the Dockerfile. Combined with a relative lack of documentation, this leads to user confusion.

It would be best to add a build: section in the docker-compose configuration, which will automatically build and tag the image when the configuration is run.

Side note: have we considered pushing an actual official px4flightreview image to Docker Hub? It may be useful to have.

bbworld1 avatar Feb 15 '21 18:02 bbworld1

Hi Feel free to suggest any changes you'd like to see via PR. Personally I don't use docker for this.

bkueng avatar Feb 16 '21 07:02 bkueng

Thanks, I've added it at #207 here.

Docker Hub pushes are trivial to automate now that docker-compose handles building (simply docker-compose build, then docker-compose push), if that's an option you want to explore.

bbworld1 avatar Feb 16 '21 08:02 bbworld1