PX4-user_guide icon indicating copy to clipboard operation
PX4-user_guide copied to clipboard

Control Surfaceless VTOL Quad Tailsitters Documentational Error

Open aoberai opened this issue 3 years ago • 8 comments

https://docs.px4.io/master/en/frames_vtol/tailsitter.html

This page suggests that VTOL Quad Tailsitters without elevons (control surfaceless) are supported by PX4 which is not true; pitch and roll differential thrust don't exist for control surfaceless vtol tailsitters with PX4. For the PX4, elevons are mandatory and the documentation should be updated to show this.

aoberai avatar May 30 '22 16:05 aoberai

Thanks @aoberai

@RomanBapst Can you confirm? The specific text here says "Four rotor VTOL with optional elevons. Uses rotors to transition between modes (along with elevons if present)., which was my understanding.

How would you reword?

hamishwillee avatar Jun 01 '22 01:06 hamishwillee

Or @sfuhrer Might you be able to comment?

hamishwillee avatar Jun 02 '22 02:06 hamishwillee

Maybe "Four rotor VTOL with elevons for pitch/roll control in cruise flight. Uses rotors along with elevons to transition between modes."

sfuhrer avatar Jun 02 '22 06:06 sfuhrer

Once we have made the small code adjustments to support elevon-less flights and tested it we can revert to the previous version.

sfuhrer avatar Jun 02 '22 06:06 sfuhrer

Do you know what the timeline on "small code adjustments to support elevon-less flights and tested it we can revert to the previous version" would be? I would be happy to pr it in if people are busy, do you have any advice on where to look?

aoberai avatar Jun 02 '22 06:06 aoberai

Do you know what the timeline on "small code adjustments to support elevon-less flights and tested it we can revert to the previous version" would be? I would be happy to pr it in if people are busy, do you have any advice on where to look?

I would have said a couple of weeks. This branch gives you some ideas of what the changes are about, though it's not in a flyable state I think https://github.com/PX4/PX4-Autopilot/commits/quad-tailsitter-no-surfaces-testing

sfuhrer avatar Jun 02 '22 07:06 sfuhrer

@aoberai The minimal patch for this would be something like:

  1. start from here https://github.com/PX4/PX4-Autopilot/commits/quad-tailsitter-no-surfaces-testing as @sfuhrer mentioned
  2. revert the last commit there -- this was a specific hard coded mixer change for a particular airframe's mixer
  3. additionally add in a scaler for the pitch and roll differential thrusts, as is done with the parameter param_vt_fw_difthr_sc for the yaw axis already

Would be great if you could take a stab at a PR @aoberai -- I likely wont have time to look at this for at least the next week, but @sfuhrer and I could give you pointers if you make the code changes.

tstastny avatar Jun 08 '22 13:06 tstastny

Thanks @sfuhrer (et al). Given you're actively looking at working on this I'd rather leave this open for a few weeks and see how it develops than update the docs :-)

hamishwillee avatar Jun 09 '22 00:06 hamishwillee