PX4-Autopilot icon indicating copy to clipboard operation
PX4-Autopilot copied to clipboard
verified publisher icon PX4

ci: use new container for checks worflow

Open mrpollo opened this issue 6 months ago • 3 comments

few commits to update CI throughout

  • Single asterisk ('*') won't work for 'release/v1.16' branches, updating to double asterisk fixes this
  • Cancel concurrent jobs to save on computing time
  • Enable workflows on changes to .github/workflows directory, otherwise it's hard to test changes on those files. Keeps the ignore path to workflows for push events.
  • shellcheck fixes with updated compiler
    • Fixes SC2268
    • Fixes SC3014
  • ignore lcov mismatch errors
  • enable atomic profile updates for coverage builds

mrpollo avatar Jun 17 '25 16:06 mrpollo

Oh totally missed this pr, good work looks good overall.

PetervdPerk-NXP avatar Jun 17 '25 20:06 PetervdPerk-NXP

@MaEtUgR I fixed a few conditional checks in an init script you previously committed, just wanted to raise your attention and check if you intended those for any reason, and if I'm good with my fixes

mrpollo avatar Jun 17 '25 22:06 mrpollo

@PetervdPerk-NXP, sorry for the delay on your PR It's likely unrelated to any of this, but I still want to get you a green build before we merge. I'll be waiting for @bkueng to review this before I merge, due to the fixes in the build, in particular the shellcheck, and the lcov stuff

mrpollo avatar Jun 17 '25 22:06 mrpollo

@bkueng thanks for the review I went ahead and implemented your suggestions and resolved the comments, whenver you are ready please review/merge thank you.

mrpollo avatar Jun 23 '25 16:06 mrpollo

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-dev-call-june-25-2025-team-sync-and-community-q-a/46161/2

DronecodeBot avatar Jun 25 '25 14:06 DronecodeBot

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-dev-call-july-2-2025-team-sync-and-community-q-a/46266/4

DronecodeBot avatar Jul 02 '25 15:07 DronecodeBot

@dagar I moved over the coverage cmake flags to the coverage.cmake file and tests everything works, also CI works

mrpollo avatar Jul 02 '25 21:07 mrpollo