PX4-Autopilot icon indicating copy to clipboard operation
PX4-Autopilot copied to clipboard

nxp/imxrt_common/main:Fix Breakage from a9962dc

Open davids5 opened this issue 1 year ago • 3 comments

This was merged and will not even compile. There are babies being thrown out in the bathwater! - CI needs to be Fixed.

davids5 avatar May 23 '24 12:05 davids5

~~This is waiting on a nuttx change.......~~ Done

davids5 avatar May 23 '24 16:05 davids5

Oh dear. Thanks @davids5 !

julianoes avatar May 23 '24 21:05 julianoes

Ok so once this compiled is did not boot. The Cause was that the last commit on Nuttx 0f401a6062653795b6355c420ea8b0e72578c204 cause the ITCM to be write protected, which caused fault on reboot.

The Fix is adding an additional mpu_configure_region(IMXRT_ITCM_BASE, 256 * 1024, before jumping to the APP.

But a bug in NuttX was preventing the MPU reset prior to reinitialization. - This has been fixed, unstreamed and backported.

@igalloway @PetervdPerk-NXP @vincentpoont2 : Bootloader replacement is needed! This PR provides a working bootloader and APP and should installed on all HW. Using PX4 after 470bea9ba84ac6202a707b263bbc2ddee4305b93 will fail to boot without the bootloader from this PR.

davids5 avatar May 25 '24 08:05 davids5

Thanks David, Peter.

@dk7xe we will need to offline plan for updating the bootloader in the existing validation units.

igalloway avatar May 25 '24 12:05 igalloway

Thanks for the build and CI fix David! Is this still blocked or verified to solve the issues now? As far as I can see the remaining CI errors are not related. Let's work through and get them all fixed. We can coordinate in the dev call in a few minutes.

MaEtUgR avatar May 29 '24 14:05 MaEtUgR

Thanks for the build and CI fix David! Is this still blocked or verified to solve the issues now? As far as I can see the remaining CI errors are not related. Let's work through and get them all fixed. We can coordinate in the dev call in a few minutes.

@MaEtUgR It is ready to come in and get backported to the 1.15 backports

davids5 avatar May 29 '24 14:05 davids5

Thanks again 👍 image

MaEtUgR avatar May 29 '24 16:05 MaEtUgR