PX4
rc.interface: also save empty ESC mask (none)
Describe problem solved by this pull request
Credits to @eyeam3 for pointing out to me that these ifs do not help because the ESC mask should always be saved.
If the environmental variable is any string in this case "none", then the integer parameter gets set to 0 which is exactly what we want.
Admittedly I did not find any real case in which the variables are none it could in principle still happen and in that case the mask is wrongly set after switching airframe/output configuration.
Describe your solution
I removed the ifs again that were in my understanding experimentally added in https://github.com/PX4/PX4-Autopilot/commit/7c0165ea0c4f783c1d49a9446d5559248c0cc171 from https://github.com/PX4/PX4-Autopilot/pull/18769 to work against some CI issues.
Test data / coverage
See screenshot of what the command does with none.
Additional context
Related to https://github.com/PX4/PX4-Autopilot/pull/17833
@julianoes I'm not sure anymore. Some SITL tests are failing on this pr even though I think they shouldn't. Does the command and hence the startup script fail in SITL? 🤔 I have to look into the details before we merge.
Maybe you were onto something with your original fix. But why would it only happen in the VTOL SITL CI tests and run real vehicles and quad SITL fine 🤔 🔍
Like @dagar corrected this is only relevant for the 1.13 release and not on main anymore. I ported the change to the release branch and am adding it for the sake of completeness.
Like @dagar corrected this is only relevant for the 1.13 release and not on
mainanymore. I ported the change to the release branch and am adding it for the sake of completeness.
It seems that release/1.13 still doesn't include this change. Should we merge this PR then?
