PX4-Autopilot icon indicating copy to clipboard operation
PX4-Autopilot copied to clipboard

CUAV V6X board support

Open davids5 opened this issue 3 years ago • 3 comments

Continuing https://github.com/PX4/PX4-Autopilot/pull/19750 here.

Rebased on current master.

davids5 avatar Jun 20 '22 18:06 davids5

@davids5 I believe your proposed change for the RM3100 self test bug does not address the fundamental problem with the current self test implementation. The software timeout needs to be greater than what is programmed into the RM3100 BIST register (0x33). The current implementation sets the BW and BP bits to all 1's (the maximum value). This equates to a timeout value of 480us (4 sleep oscillation cycles per LR timeout period and 4 LR periods for BIST) according to the latest published datasheet. Currently, the driver is waiting 26ms (2*RM3100_INTERVAL) which is significantly longer than required. See pull request #19583 for a proposed fix to address the RM3100 self test failures. I’d be interested to know if my proposed changes address the RM3100 self test failures you are experiencing on your flight controller.

@bmeagher - Thank you! This was not my work, just a continuation of a PR I could not write to.

@mxiaogit Let's drop 8ea548d and when https://github.com/PX4/PX4-Autopilot/pull/19583 comes it will be fixed

davids5 avatar Jun 23 '22 09:06 davids5

@davids5 I believe your proposed change for the RM3100 self test bug does not address the fundamental problem with the current self test implementation. The software timeout needs to be greater than what is programmed into the RM3100 BIST register (0x33). The current implementation sets the BW and BP bits to all 1's (the maximum value). This equates to a timeout value of 480us (4 sleep oscillation cycles per LR timeout period and 4 LR periods for BIST) according to the latest published datasheet. Currently, the driver is waiting 26ms (2*RM3100_INTERVAL) which is significantly longer than required. See pull request #19583 for a proposed fix to address the RM3100 self test failures. I’d be interested to know if my proposed changes address the RM3100 self test failures you are experiencing on your flight controller.

@bmeagher - Thank you! This was not my work, just a continuation of a PR I could not write to.

@mxiaogit Let's drop 8ea548d and when #19583 comes it will be fixed

@davids5 Yes, we can delete it.

mxiaogit avatar Jun 24 '22 09:06 mxiaogit

@mxiaogit - I have dropped that commit and rebased on current master.

davids5 avatar Jun 24 '22 10:06 davids5

@davids5 Pixhawk V6X kit will include CAN PMU Lite, can you enable Dronecan battery monitor by default?

cuhome avatar Sep 14 '22 08:09 cuhome

@davids5 Pixhawk V6X kit will include CAN PMU Lite, can you enable Dronecan battery monitor by default?

@cuhome Please do a PR against this PR and test it.

davids5 avatar Sep 14 '22 13:09 davids5

You want to backport this for v1.13.1?

dagar avatar Sep 22 '22 15:09 dagar

@dagar - was in the middle of testing and had 2 meetings. I Give me a bit....

davids5 avatar Sep 22 '22 15:09 davids5

Well good news it works

davids5 avatar Sep 22 '22 15:09 davids5

@dagar I do not have time to do the back port do you?

davids5 avatar Sep 22 '22 15:09 davids5

@dagar @davids5 This pr was not merged into the newly released 1.13.1stable, but was merged in 1.13.0master, can you please help me? image

cuhome avatar Nov 09 '22 07:11 cuhome

@dagar @julianoes can you help me get this PR into 1.13 please?

mrpollo avatar Nov 24 '22 02:11 mrpollo

The v1.13.2 has been released but I have no objections to a v1.13.3 once more backports like this one are in.

julianoes avatar Nov 24 '22 20:11 julianoes

@julianoes we need to make sure things like this don't slip from releases, there doesn't seem to be any process for that currently

mrpollo avatar Nov 25 '22 16:11 mrpollo

I don't have the overview of all these things and what needs to be backported, sorry.

julianoes avatar Dec 03 '22 18:12 julianoes

@davids5 @dagar How should we deal with it?

cuhome avatar Dec 05 '22 14:12 cuhome

@cuhome we are working on a point release for your hardware

mrpollo avatar Dec 05 '22 16:12 mrpollo

I'm verifying things here.

dagar avatar Dec 06 '22 02:12 dagar

image @dagar Thanks, when there is no gps positioning, the wrong altitude (>1000) (local_position_ned) appears.

cuhome avatar Dec 06 '22 03:12 cuhome

image

cuhome avatar Dec 06 '22 03:12 cuhome

@cuhome there's a PR for this #21765

mrpollo avatar Jun 26 '23 18:06 mrpollo