Vincent Petry

Results 443 comments of Vincent Petry

seems it won't be that easy: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-paths the docs state that excluding runs that are "expected" to pass will prevent merging edit: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks a bit cumbersome :-/

anyway, there's probably more to gain by skipping the php tests in Drone than in the workflows

idea: if we're ok to have some jobs as non-expected, we could also add the conditions only to those. some candidates for that: - all Oracle jobs - the external...

so disabling it by default might cause problems in some scenarios ?

I've lost quite some time believing this was already merged and kept compiling and trying different node versions. I should have looked at the exact failure to see that it...

I've rebased this and added the post-build step next up: - [x] local test

tested locally, while it does run those commands, there's another separate issue: in README we tell people to run "make build-js-production" and now that would include those commands. however the...

for reference, this is the local output on my setup: ``` % npm run sass && npm run sass:icons > [email protected] sass > sass --load-path core/css core/css/ apps/*/css Error: Undefined...