server icon indicating copy to clipboard operation
server copied to clipboard

Remake website property saving with Vue

Open Pytal opened this issue 3 years ago • 1 comments
trafficstars

Remake website property saving with Vue for accessibility purposes

Deprecation

The lookupServerUploadEnabled block https://github.com/nextcloud/server/blob/16b06dd75889bef318881a4783cff03aaeb971d9/apps/settings/templates/settings/personal/personal.info.php#L164-L191 is deprecated and therefore not brought over as it is only displayed under the condition that your website is set and the scope is public which is never the case as the public scope was deprecated in 21.0.1 https://github.com/nextcloud/server/blob/16b06dd75889bef318881a4783cff03aaeb971d9/lib/public/Accounts/IAccountManager.php#L86-L91

Pytal avatar Jul 21 '22 19:07 Pytal

Possible performance regression detected

Show Output
1 queries added

≠ /remote.php/dav/files/test with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/test.txt with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/many_files with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test/new_file.txt

github-actions[bot] avatar Jul 21 '22 19:07 github-actions[bot]

Rebased

Pytal avatar Aug 26 '22 00:08 Pytal

@Pytal conflicts

PVince81 avatar Aug 26 '22 06:08 PVince81

@Pytal conflicts

There will be many rebases

Pytal avatar Aug 26 '22 18:08 Pytal