Results 8 comments of PKEuS

Removing the "autostart" option was a really bad idea imho. Of course this option should not be selected by default, but it should be available optionally. The point that "there...

Removing it manually is no problem, adding it manually is, since uninstallation of KVIrc will leave a dead link then. Thus it would be nice to get the option back...

> Now all the checks for "Dangerous usage of c_str()" can probably be removed as the lifetime checker should catch all of those. Would be nice, but it does not...

I needed some time to find out what is going on here... Why does it fail only in unix builds? What is failing? testclangimport.cpp is not compiled on Windows at...

It seems like that (useless) clang import code stores Variable* that get invalidated while function arguments are being added. Fixed that, however, I would still suggest to remove that clang...

I do not see a point in splitting up pull requests (as pull requests are a pain in the ass). It is not meant to be squashed to a single...

There is no need to do so, iirc github gives you the choice between merging, rebasing and squashing.

I would update the corresponding commit.