Peter Strömberg comments

Results 545 comments of


                                            Peter Strömberg

Code loses syntax colors when switching from one window to the other

OK. So I have forgotten about this issue. Not that I have many better ideas today, but anyway, I'll have a look.

Code loses syntax colors when switching from one window to the other

> @PEZ Do you know off-hand why this happens? Is this just an effect of the VS Code API when Calva edits a file, or is Calva setting the output...

Scanner test error

Thanks! It should be pretty easy to reproduce this. What I tend to do is create a non-property test with the input that the generator has found. Just looking at...

Paredit auto collapsing whitespace left of the cursor is disorienting

Thanks! Iirc there is some code used by the `backspace` Paredit function that possibly can be put in use for this purpose as well. It might be a matter of...

Indenter and formatter fails while typing out body of deftype method

Copying comment from #1956 as well: The cause here is that Calva only formats the enclosing form, so `deftype` is never considered. backspace causes the parent form to be formatted,...

Indenter and formatter fails while typing out body of deftype method

I think that the tools to solve this involve: 1. The TokenCursor to identify when we're at the top level of a `deftype` method. * We have a function for...

Indenter and formatter fails while typing out body of deftype method

I can still reproduce this here: https://github.com/BetterThanTomorrow/calva/blob/dev/test-data/indenter-cases.clj#L37

Indenter and formatter fails while typing out body of deftype method

@SillyCoon, there are two indentation mechanisms in play for this. The one tested in your PR, which we can call the _indenter_, and also the _formatter_. I don't understand why...

Indenter and formatter fails while typing out body of deftype method

This issue is fixed. We must have missed to include a closing commit.

Indenter and formatter fails while typing out body of deftype method

That said, I am experiencing weird indentation issues quite often lately. Which could be regressions from the fixing of this issue. I'll try figure out a repro. It happens to...