Peter Doak

So we support global estimators but the semantics must be clear. I propose Global estimators are permanent, they are present for all sections and it is illegal to define another...

I don't think deprecation of new usage of the preprocessor define needs any additional coordination at all. I can't think of a case where you can't check whether ValueType is...

I feel like this option still leaves the concurrent operation of the rotational optimization very unclear IMHO. And the root cause of this is because of the index = 0...

`walker_configurations_` I think is descriptive of what this particle set is doing. I think. @markdewing should weight in. ParticleSet is a garbage bag that can contain anything from just a...

I will revisit a the possibility of a const view and psiMinv ownership after the different accelerated flavors of direct inversion are in.

I think 1 and 2 are probably correct. I'm working through my too clever copy constructor in 3 but I'm not sure that will put the logic in clone.

I'm all for disallowing type 3 Well I've made a problem by writing lots of code with the convention ```C++ VariableType get_variable_name() const { return variable_name_; } ``` While I...

I think this makes sense. And I think its probably better for development as well. Builds away from the "suggested" require more flags but their intent reads clearly. I assume...

I think QMC_CUDA2HIP is just a terrible flag and without reading the cmake again I couldn't tell you what parts of the native CUDA code it effects. I know exactly...

Someone else should weigh in on this. It's an obscuring flag for development and troubleshooting since now the easy visibility of the ENABLE flags is removed. I think its best...